TCP pings are bugged #3448

@radistmorse

Description

This new functionality was introduced in #2622 . This functionality causes my client to disconnect 5 seconds after joining. This can repeat several times in a row, but happens only eventually. I have yet to find the pattern when it happens. I use the 1.3.0 snapshot client, and 1.2.19 server. At the very least, the message is misleading, since my server doesn't use TCP (the port is not even forwarded).

There is also a definite bug in how the "maxinflighttcppings" parameter is handled: if it's zero, the feature does not get disabled, but rather the client is disconnected immediately after the connection. This line https://github.com/mumble-voip/mumble/blob/master/src/mumble/ServerHandler.cpp#L471 should have both > instead of >=.